Migrate pipelines and profiling code to ST::string
#1512
Conversation
|
Due to the changes to pfDXPipeline, this will be deferred until after #1326 is merged. |
dgelessus
force-pushed
the
pipelines_and_profiler_st_string
branch
2 times, most recently
from
6a8a6ed to
5a3abde
Compare
dgelessus
force-pushed
the
pipelines_and_profiler_st_string
branch
from
5a3abde to
f34edf7
Compare
| if (!groupName) | ||
| groupName = "General"; |
There was a problem hiding this comment.
What happens if an empty groupName is passed in now?
There was a problem hiding this comment.
Nothing, like for any other group that doesn't exist.
It looks to me like this was a special case for the Stats.Show console command to default to General if you don't pass an argument. I changed the command implementation to handle that case properly, so this workaround shouldn't be needed anymore.
dgelessus
force-pushed
the
pipelines_and_profiler_st_string
branch
from
f34edf7 to
9324f4b
Compare
dgelessus
force-pushed
the
pipelines_and_profiler_st_string
branch
from
9324f4b to
257571f
Compare
|
@dpogue, @colincornaby Have y'all had a chance to look at this? It has a lot of pipeline adjacent type stuff, so I'd like to get your input. |
dgelessus
force-pushed
the
pipelines_and_profiler_st_string
branch
from
257571f to
924070e
Compare
|
(rebased again to integrate #1578 and get off of the spicy version of liblzma) |
|
I'll take a look in the next few hours. |
Just some cleanup to replace more C-style string manipulation and fixed-size buffers. This should have no visible effect.
Almost all of these are "boring" changes. The only somewhat complex parts are the number formatting in
plProfileBaseand the graphics adapter/driver name checks inhsG3DDeviceSelector.