-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Python access to plLayer and ImageLibMod textures. #1360
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should probably toss the whole BUILDING_PYPLASMA
thing from the new code. It makes things hard to follow.
I agree, and was thinking the same thing (which is why I asked about it in the chat last week). It's useless to us, unfortunately, and just makes everything harder to read. I'll remove it from this one. Doing all of pfPython was going to affect a lot of files though, so I haven't done it yet. Will probably open a separate PR for that. |
83844be
to
9dfe1fd
Compare
b6477bd
to
5c46d85
Compare
What is the status here? |
Working on a few things to get it finished up, but my time has been limited. I hope we can finish this one soon. :) |
This isn't needed because the layer will do it once the new reference is delivered by the resmgr.
Maybe the previous code worked, but it wasn't the correct way to handle old style function call argument parsing.
Yas, another helper.
@Deledrius I've done a pass on everything to fix a few nits. I also added two new helpers: layer = PtFindLayer("Map #38", age="GUI", page="GUIDialog04a")
tex = PtFindImage("xavatarcustom")
PtDebugPrint(f"hello {layer=}, {tex=}")
layer.setTexture(next(iter(tex))) Let me know if you have any concerns. I'm OK with merging the start up changes as-is without a corresponding assets PR. |
Co-authored-by: Joseph Davies <[email protected]>
In order to facilitate the expansion of existing Ages as well as adding new Fan Ages, this PR provides a way to modify textures dynamically through Python scripts. It is especially ideal for otherwise-identical meshes whose appearance can be easily changed with only a texture swap. Book covers and Linking Panels are the primary intended targets.
Planned uses:
This PR:
Questions for reviewers: