Fix Linking Book cover function #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust script to actually use cover image defined in xLinkingBookDefs.py
Hazado
suggested changes
Feb 27, 2023
Comment on lines
530
to
533
| if not showOpen and not self.IsThereACover(bookdef): | ||
| showOpen = 1 | ||
| else: | ||
| showOpen = 0 |
There was a problem hiding this comment.
Suggested change
| if not showOpen and not self.IsThereACover(bookdef): | |
| showOpen = 1 | |
| else: | |
| showOpen = 0 | |
| if showOpen and self.IsThereACover(bookdef): | |
| showOpen = 0 |
There was a problem hiding this comment.
Also Line 867 if idx > 0: should be if idx >= 0:
Anything other than -1 is true for string find
* New elif line to weed out opened pedestal Books without covers defined. Should fix Books getting default cover for no reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust script to actually use cover image defined in
xLinkingBookDefs.py. Fixes #1338The script currently makes the Relto shelf and some other Books gain the "default" cover and/or extra pages, so it's a draft for now.