2.1.3-rc #66
Merged
2.1.3-rc #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Gyarbij
commented
Sep 2, 2024
Gyarbij
commented
- Refactor plex.py to fix cache initialization
- Refactor plexist.py to persist cache
- Refactor plex.py to improve caching
- Added tenacity for implementing retry logic.
- Update requirements.txt to include tenacity library
- Refactor plex.py for improved matching and logging
- remove: global match threshold in favor of type match threshold
- Update SECURITY.md to include supported versions and reporting instructions
- Update docker-compose.yml filename to compose.yaml, update file contents and update readme.
- refine match scoring
- Update plex.py: Use the DB_PATH environment variable, with a default fallback.
2.1.5 DEV
Use the DB_PATH environment variable, with a default fallback
…fallback. New match func that, starts with a strict matching criteria, including title, artist, and album. If no match is found, it relaxes the album requirement and searches again. If still no match, it uses only the first two words of the title (if available) along with the artist. It uses a scoring system that weights title, artist, and album differently. It also checks for version information in parentheses and factors that into the score. The thresholds for accepting a match are different at each stage, becoming more lenient as we progress. It provides more detailed logging about why a match was accepted at a particular stage. Changed the initial check from if tracks is None to if not tracks. This will handle both None and empty lists. Moved the plex.playlist(playlist.name) call inside the try block. This ensures we're not trying to access a playlist that doesn't exist. Improved error handling by catching specific exceptions and logging the error messages. Added more detailed logging, including success messages for updating description and poster. Changed some logging.info calls to logging.error or logging.warning where appropriate. Simplified the logic for handling missing tracks CSV files. Ensured consistent use of string formatting in logging calls.
…nts and update readme.
- Implemented a caching mechanism using a global dictionary plex_tracks_cache to store all Plex tracks. - Added function fetch_all_plex_tracks that fetches all tracks from Plex and caches them, function uses @Retry decorator to handle temporary network issues. - Modified _get_available_plex_tracks to use the cached tracks instead of performing multiple searches. - Updated _match_single_track to work with the cached tracks instead of performing Plex searches. - Added retry mechanisms to _update_plex_playlist and update_or_create_plex_playlist functions. - Added a clear_cache function to clear the cache when needed (e.g., between runs or when you want to force a refresh).
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
This was
linked to
issues
Sep 2, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.