Create a new pull request by comparing changes across two branches #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an esm import integration test and updates the commonjs integration test.
* Fixes a broken link to /api/operators/switchMapTo * Fixes a typo in the label for switchMapTo
This removes deps that were added ages ago to resolve different package conflicts that simply are not necessary now.
BREAKING CHANGE: `observable` (the `Symbol.observable` symbol instance) is no longer exported. Use a polyfill like `symbol-observable`, or use `Symbol.observable ?? '@@observable'` as a workaround.
* refactor: removes pipeFromArray This refactor is in preparation to move Observable and other core elements into its own package. - Note that the `pipeReducer` is repeated in a few places. This is okay, just a step in the refactor * refactor: move all core implementations to Observable.ts This is in preparation for publishing `Observable` and related types as a standalone package. - Moves `Subscriber`, `Subscription`, `config`, and `from` to `Observable.ts` - Moves several related types to `Observable.ts` - Updates imports to reflect the new locations. * refactor: Move UnsubscriptionError to Observable.ts Moves UnsubscriptionError to Observable.ts, since that's the only place it is used. * refactor: unify observable input checking order and error throwing Unifies and centralizes the order of input checking and how we throw errors when something cannot be converted to an observable. * refactor: Move simple typeguards to Observable.ts - Since we unified how we were checking the observable input types, we no longer need shared modules for each typeguard. - Most of the files touched here were using `isFunction`, etc. * refactor: move notification factories under Observable.ts - This is in preparation for moving Observable and related types to its own packages * chore: fix lint
* chore: migrate to eslint This just removes tslint and its associated packages, replacing them with eslint and `@typescript-eslint`. Any custom rule config we had has been discarded so we can instead rely on the recommended configs from both eslint and tseslint. * test: revert args in test
* chore: update yarn.lock to fix broken build * chore: ensure core-js exists
BREAKING CHANGE: Removed the deprecated `Subject.create` method. If you need to create an object that is "half Observable, half Observer", you'll need to either bolt `next`, `error`, and `complete` handlers onto an `Observable` and property type the return... or you'll need to create your own class that is backed by an `Observable`. In any case, if the `Observer` and the `Observable` are so unrelated that you have to bolt them together, you're probably better off with those two objects separately. This is why `Subject.create` has been deprecated for so long.
…input` and `output`.
BREAKING CHANGE: `WebSocketSubject` is no longer `instanceof Subject`. Check for `instanceof WebSocketSubject` instead.
* chore: set primary node version and yarn v1 package manager * chore: replace volta with engines
* style: automatic type-only imports * style: automatic type-only exports * chore: fix formatting --------- Co-authored-by: Ben Lesh <[email protected]>
Allow passing a value of type `symbol` to `eventName` if a `NodeStyleEventEmitter` is passed to `source`, according to [the documentation](https://nodejs.org/api/events.html#emitteraddlistenereventname-listener). Closes #7338
This goes through and moves all of the reliance on the `this` context for scheduling to a single point, `executeSchedule`. It also moves common complexities to that helper function. All of this is done in preparation for creating newer, simplified schedulers
This reverts commit d42594f. This was pushed up by mistake.
* chore(repo): misc QOL release * chore(repo): update publish checks and logic * chore: write branch out in error case. * chore: add configuration for npm tags and better error messages --------- Co-authored-by: Ben Lesh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
BREAKING CHANGE:
Related issue (if exists):