Add Apple app store flag to remove APIs prohibited in App Store distributions - #424
Merged
GuillaumeGomez merged 4 commits intoFeb 3, 2021
Merged
Conversation
iOS apps are sandboxed and unable to fetch this information at all
Owner
|
That's a bit disappointing but I guess we can't do anything about it... Can you add a CI suite for it to ensure that it compiles fine with this feature enabled please? |
complexspaces
force-pushed
the
app-store-flag
branch
from
February 2, 2021 22:38
a8c927b to
07936e6
Compare
Contributor
Author
|
I just pushed CI that runs the Apple targets with the feature flag. |
Owner
|
You broke the CI apparently. 😆 |
complexspaces
force-pushed
the
app-store-flag
branch
2 times, most recently
from
February 3, 2021 14:32
d252232 to
6773277
Compare
complexspaces
force-pushed
the
app-store-flag
branch
from
February 3, 2021 14:44
6773277 to
6547a2d
Compare
Contributor
Author
|
CI is passing again. The new job looks like this and only runs on Apple targets: |
GuillaumeGomez
approved these changes
Feb 3, 2021
Owner
|
Thanks a lot! For the next release, I'll wait for your other PR to be merged if you don't mind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes two things with sysinfo:
apple-app-storeflag that disables MacOS process information when enabled. The APIs used bysysinfoare considered "internal only" by Apple and get flagged during the App Store review process.The second point is the more unfortunate one. Even if the an application does not use
sysinfo's process functionality, the symbols still exist and are flagged, preventing applications usingsysinfofrom being put on the App store at all. The flag is not enabled by default, instead requiring users to opt in because the process APIs and functions are still valid to use in third-party distributed apps.