Skip to content

Commit

Permalink
revert changes and just delete the fixme
Browse files Browse the repository at this point in the history
Avoiding the naming didn't have any meaningful perf impact.
  • Loading branch information
erikdesjardins committed Mar 16, 2024
1 parent 9476fe7 commit ff2b405
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions src/builder.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
use std::borrow::Cow;
use std::cell::Cell;
use std::convert::TryFrom;
use std::fmt::Display;
use std::ops::Deref;

use gccjit::{
Expand Down Expand Up @@ -527,14 +526,14 @@ impl<'a, 'gcc, 'tcx> BuilderMethods<'a, 'tcx> for Builder<'a, 'gcc, 'tcx> {
self.block
}

fn append_block(cx: &'a CodegenCx<'gcc, 'tcx>, func: RValue<'gcc>, name: impl Display) -> Block<'gcc> {
fn append_block(cx: &'a CodegenCx<'gcc, 'tcx>, func: RValue<'gcc>, name: &str) -> Block<'gcc> {
let func = cx.rvalue_as_function(func);
func.new_block(name.to_string())
func.new_block(name)
}

fn append_sibling_block(&mut self, name: impl Display) -> Block<'gcc> {
fn append_sibling_block(&mut self, name: &str) -> Block<'gcc> {
let func = self.current_func();
func.new_block(name.to_string())
func.new_block(name)
}

fn switch_to_block(&mut self, block: Self::BasicBlock) {
Expand Down

0 comments on commit ff2b405

Please sign in to comment.