Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #18

Merged
merged 2 commits into from
Mar 7, 2020
Merged

Update #18

merged 2 commits into from
Mar 7, 2020

Conversation

GuillaumeGomez
Copy link
Owner

Fixes #17

Is it enough for you @BurntSushi or do you have something else in mind?

@GuillaumeGomez
Copy link
Owner Author

I'll maybe write a small blog post about it to make this fact more widely known.

Copy link

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! And yes, a blog post sounds great. :-) I think you nailed this particular problem!

@GuillaumeGomez
Copy link
Owner Author

Cool! Writing it then. Meanwhile, merging and publishing the new crate version.

@GuillaumeGomez GuillaumeGomez merged commit 3a3142e into master Mar 7, 2020
@GuillaumeGomez GuillaumeGomez deleted the update branch March 7, 2020 20:25
@BurntSushi
Copy link

Oh, wait, perhaps I wasn't going crazy. It looks like cfg(doctest) was just recently stabilized? rust-lang/rust#63803

Does that mean it used to work with cfg(test) but now it no longer does?

@GuillaumeGomez
Copy link
Owner Author

Yep, it's been a huge debate. Don't know why, I thought you've been part of it... But no: you're not crazy. It's stable only since 1.40! I made the blog post btw: https://blog.guillaume-gomez.fr/articles/2020-03-07+cfg%28doctest%29+is+stable+and+you+should+use+it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doctest! seems to not work any more?
2 participants