Allow to use the click command on an option in a select - #759
Merged
Conversation
GuillaumeGomez
changed the title
click command on an option in a selectclick command on an option in a select
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 16, 2026
…r=Urgau [rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore) Part of rust-lang#152197 You can see the original code of this test in rust-lang#152194 (where it was removed). The `browser-ui-test` update comes from GuillaumeGomez/browser-UI-test#759. We can now use the `click` command to click on an `option` inside a `select` (surprisingly enough, it needs to be special-cased in puppeteer...). That update allowed me to replace all the `press-key` with one `click`. Starting from this change, I couldn't reproduce the failure, so hopefully it's gone. cc @notriddle @JonathanBrouwer r? @Urgau
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 16, 2026
…r=Urgau [rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore) Part of rust-lang#152197 You can see the original code of this test in rust-lang#152194 (where it was removed). The `browser-ui-test` update comes from GuillaumeGomez/browser-UI-test#759. We can now use the `click` command to click on an `option` inside a `select` (surprisingly enough, it needs to be special-cased in puppeteer...). That update allowed me to replace all the `press-key` with one `click`. Starting from this change, I couldn't reproduce the failure, so hopefully it's gone. cc @notriddle @JonathanBrouwer r? @Urgau
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 16, 2026
…r=Urgau [rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore) Part of rust-lang#152197 You can see the original code of this test in rust-lang#152194 (where it was removed). The `browser-ui-test` update comes from GuillaumeGomez/browser-UI-test#759. We can now use the `click` command to click on an `option` inside a `select` (surprisingly enough, it needs to be special-cased in puppeteer...). That update allowed me to replace all the `press-key` with one `click`. Starting from this change, I couldn't reproduce the failure, so hopefully it's gone. cc @notriddle @JonathanBrouwer r? @Urgau
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 16, 2026
…r=Urgau [rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore) Part of rust-lang#152197 You can see the original code of this test in rust-lang#152194 (where it was removed). The `browser-ui-test` update comes from GuillaumeGomez/browser-UI-test#759. We can now use the `click` command to click on an `option` inside a `select` (surprisingly enough, it needs to be special-cased in puppeteer...). That update allowed me to replace all the `press-key` with one `click`. Starting from this change, I couldn't reproduce the failure, so hopefully it's gone. cc @notriddle @JonathanBrouwer r? @Urgau
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 16, 2026
…r=Urgau [rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore) Part of rust-lang#152197 You can see the original code of this test in rust-lang#152194 (where it was removed). The `browser-ui-test` update comes from GuillaumeGomez/browser-UI-test#759. We can now use the `click` command to click on an `option` inside a `select` (surprisingly enough, it needs to be special-cased in puppeteer...). That update allowed me to replace all the `press-key` with one `click`. Starting from this change, I couldn't reproduce the failure, so hopefully it's gone. cc @notriddle @JonathanBrouwer r? @Urgau
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 16, 2026
…r=Urgau [rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore) Part of rust-lang#152197 You can see the original code of this test in rust-lang#152194 (where it was removed). The `browser-ui-test` update comes from GuillaumeGomez/browser-UI-test#759. We can now use the `click` command to click on an `option` inside a `select` (surprisingly enough, it needs to be special-cased in puppeteer...). That update allowed me to replace all the `press-key` with one `click`. Starting from this change, I couldn't reproduce the failure, so hopefully it's gone. cc @notriddle @JonathanBrouwer r? @Urgau
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 16, 2026
…r=Urgau [rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore) Part of rust-lang#152197 You can see the original code of this test in rust-lang#152194 (where it was removed). The `browser-ui-test` update comes from GuillaumeGomez/browser-UI-test#759. We can now use the `click` command to click on an `option` inside a `select` (surprisingly enough, it needs to be special-cased in puppeteer...). That update allowed me to replace all the `press-key` with one `click`. Starting from this change, I couldn't reproduce the failure, so hopefully it's gone. cc @notriddle @JonathanBrouwer r? @Urgau
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Aug 17, 2026
Rollup merge of #161148 - GuillaumeGomez:put-back-gui-test, r=Urgau [rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore) Part of #152197 You can see the original code of this test in #152194 (where it was removed). The `browser-ui-test` update comes from GuillaumeGomez/browser-UI-test#759. We can now use the `click` command to click on an `option` inside a `select` (surprisingly enough, it needs to be special-cased in puppeteer...). That update allowed me to replace all the `press-key` with one `click`. Starting from this change, I couldn't reproduce the failure, so hopefully it's gone. cc @notriddle @JonathanBrouwer r? @Urgau
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Aug 17, 2026
[rustdoc] Put back one removed flaky GUI test (which hopefully isn't flaky anymore) Part of rust-lang/rust#152197 You can see the original code of this test in rust-lang/rust#152194 (where it was removed). The `browser-ui-test` update comes from GuillaumeGomez/browser-UI-test#759. We can now use the `click` command to click on an `option` inside a `select` (surprisingly enough, it needs to be special-cased in puppeteer...). That update allowed me to replace all the `press-key` with one `click`. Starting from this change, I couldn't reproduce the failure, so hopefully it's gone. cc @notriddle @JonathanBrouwer r? @Urgau
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.