Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System font aplied only for last tab #1947

Closed
vantu5z opened this issue Oct 22, 2021 · 9 comments · Fixed by #1954
Closed

System font aplied only for last tab #1947

vantu5z opened this issue Oct 22, 2021 · 9 comments · Fixed by #1954

Comments

@vantu5z
Copy link
Contributor

vantu5z commented Oct 22, 2021

Font is good only in last tab.
Снимок экрана от 2021-10-22 15-12-06
Снимок экрана от 2021-10-22 15-12-10

Guake version 3.8.0
OS: Arch Linux

@LunaGNUisance
Copy link

LunaGNUisance commented Oct 22, 2021

I'm also facing the same issue on Arch Linux with Guake version 3.8.0. I'm facing another issue where the tabs bar isn't shown when I only have one tab open. When I start Guake, it loads for about 20 seconds, seems to fail, then GNOME freezes/goes black, core dumps, and restarts itself. Then these issues arise.

The python-gobject dependency was upgraded at the same time, so this might be related. For the moment, I've downgraded Guake to 3.7 and I no longer have these issues, but it still causes core dumps on startup. I downgraded python-gobject at the same time, thinking this was the culprit, but couldn't start Guake after this, so left it at 3.40.1-2.

EDIT: It only core dumps when I start Guake from the .desktop file; when I start it from a terminal, there are no issues.

@cmacht
Copy link

cmacht commented Oct 23, 2021

@vantu5z I had the same issue and could work around it in Guake Preferences: In "Appearance" > "General" I unticked the box "Use the system fixed width font". Alternatively, I could set my preferred font there. I concur though, it's still a bug I encountered as well in 3.8.0.

@LunaGNUisance You mention three different issues. The first one is already described here, the second one (no bar) is actually a new feature #924 and the third one (crashing) would be more helpful in a separate bug report.

@LunaGNUisance
Copy link

@cmacht I suppose you are right. I didn't want to spam the issue tracker, so I grouped the issues together (as they're all related to 3.8.0), but I suppose it would be harder to track them in the long-term this way. I'll open a separate issue for the core dump issue (which is reproducible on two of my Arch GNOME machines) when I do some further testing.

I initially thought that #924 was a bug because it looked strange to me for the bottom of the terminal to be cut off like that and not have the new tab button present, but I understand wanting to reclaim more vertical space.

I tried unchecking "Use the System fixed width font", but this doesn't work. Even the newest tab's font rendering is strange now.

guake-font-issue-1
guake-font-issue-2

@Davidy22
Copy link
Collaborator

Davidy22 commented Oct 24, 2021

Hiding the tab bar when there is one tab is a toggleable option that defaults on, you can actually restore the old behavior if you preferred it in the settings.

For the core dump, can you try moving the file ~/.config/guake/session.json somewhere else and try to start guake again? There's an issue with loading many terminals quickly that segfaults vte that we've run into some amount before which this might be related to.

For the people experiencing font issues, what's the name of the font you're using, and what font-related settings do you have? Unable to observe the issue myself, need help with reproduction

@vantu5z
Copy link
Contributor Author

vantu5z commented Oct 24, 2021

If in Guake config set "Use system mono font" then it used ony for last tab.
To reproduce:

  1. Uncheck "Use system font" in Guake config
  2. In Guake config set some font differ from your system font
  3. Set "Use system font" back
  4. Try to create new tabs and look to previous tabs.

@vantu5z vantu5z changed the title Font broken when use tabs System font aplied only for last tab Oct 24, 2021
@Davidy22
Copy link
Collaborator

Repoduction instruction still doesn't work for me, what's the actual name of your system default font?

@cmacht
Copy link

cmacht commented Oct 24, 2021

To jump in, I have set my system default monospace font to Source Code Pro Regular. When I set the font in guake preferences to something else (let's say Arial) and uncheck "Use system font" it's fine, and it uses Arial as expected.

I open three tabs in guake, all with Arial. When I then check "Use system font", all the tabs correctly turn to Source Code Pro immediately. However, if I now open a new tab, only the new tab has Source Code Pro, the three old ones immediately revert to Arial, which should not happen.

And thank you, @Davidy22 for being so active! Your engagement is really giving me a good feeling about Guake, even though everyone else on the team seems to have other plans for their weekend than fixing bugs. 😉 ❤️

@Davidy22
Copy link
Collaborator

Oh, was able to reproduce now. Also notice that affected tabs retain the font through restarts. Quick sanity check with 3.7 did not produce the bug, so a change in 3.8 caused this. Think I can figure this out.

Would have been nice if the maintainer handoff had been a full one instead of this halfway one where my changes only get merged when the one other person who was given review privileges approves them after two weeks and I have to play tech support telephone with any guake resource that isn't the github repo because I don't have direct access. Safer this way though maybe, in case the new maintainer was just going to delete the repo or something.

@LunaGNUisance
Copy link

As a workaround for now, unchecking "Use the system fixed width font" and setting the font to whatever your Monosapce text system font is, and then checking "Use the system fixed width font" will return the default behavior. I'm just noting this, for others that did not understand what the issue was at first.

I opened a separate issue for the core dump upon launch issue: #1950

Davidy22 added a commit to Davidy22/guake that referenced this issue Oct 25, 2021
Davidy22 added a commit to Davidy22/guake that referenced this issue Oct 25, 2021
gsemet pushed a commit that referenced this issue Oct 25, 2021
PhungXuanAnh pushed a commit to PhungXuanAnh/guake that referenced this issue Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants