Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 140fe7a #3612

Merged
merged 3 commits into from
Feb 3, 2024
Merged

Revert 140fe7a #3612

merged 3 commits into from
Feb 3, 2024

Conversation

CloCkWeRX
Copy link
Collaborator

@CloCkWeRX CloCkWeRX commented Feb 3, 2024

#3611

https://www.staging.growstuff.org/crops/search?term=bob

What I still don't understand is this should have test coverage for exactly the scenario that is broken in prod, but it was not failing.

describe "crop search" do
  it "search results show the search term in title" do
    visit root_path
    within "form#navbar-search" do
      fill_in "term", with: "tomato"
      click_button "Search"
    end
    expect(page).to have_css "h1", text: "Crops matching \"tomato\""
  end

@CloCkWeRX
Copy link
Collaborator Author

Extremely annoying, the specs that have broken are.... the JSON versions of what is broken in the HTML version.

@CloCkWeRX CloCkWeRX marked this pull request as ready for review February 3, 2024 23:55
@CloCkWeRX CloCkWeRX merged commit 6102f06 into dev Feb 3, 2024
6 checks passed
@CloCkWeRX CloCkWeRX deleted the revert-140fe7a branch February 3, 2024 23:55
@CloCkWeRX CloCkWeRX mentioned this pull request Feb 4, 2024
CloCkWeRX added a commit that referenced this pull request Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant