Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix haml preview #3610

Merged
merged 22 commits into from
Feb 4, 2024
Merged

Fix haml preview #3610

merged 22 commits into from
Feb 4, 2024

Conversation

CloCkWeRX
Copy link
Collaborator

@CloCkWeRX CloCkWeRX commented Feb 3, 2024

Attempts to fix markdown showing in the previews of posts, by rendering to HTML first then truncating:
https://growstuff-staging.herokuapp.com/posts

image

@CloCkWeRX CloCkWeRX changed the base branch from dev to bump-haml February 3, 2024 04:42
Base automatically changed from bump-haml to dev February 3, 2024 07:03
@CloCkWeRX CloCkWeRX marked this pull request as ready for review February 4, 2024 00:28
@CloCkWeRX
Copy link
Collaborator Author

Well, this does fix the preview by forcing the markdown to be rendered.
But it highlighted that our growstuff_markdown utility... isn't actually translating crops when it's interpolated, which is how it's used.

app/views/posts/_single.html.haml Dismissed Show dismissed Hide dismissed
@CloCkWeRX CloCkWeRX merged commit 49284eb into dev Feb 4, 2024
6 checks passed
@CloCkWeRX CloCkWeRX deleted the fix-haml-preview branch February 4, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant