Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codespaces #3279

Merged
merged 47 commits into from
Apr 13, 2023
Merged

Codespaces #3279

merged 47 commits into from
Apr 13, 2023

Conversation

CloCkWeRX
Copy link
Collaborator

@CloCkWeRX CloCkWeRX commented Mar 13, 2023 •
edited
Loading

Was #3216

Squash merge!

@CloCkWeRX
Copy link
Collaborator Author

Frustrating:
Container starts, you can curl elasticsearch.

Bundles.

You try to curl elasticsearch.

Name no longer resolves!

@CloCkWeRX
Copy link
Collaborator Author

Okay, restarting everything made it much more stable!

@CloCkWeRX CloCkWeRX marked this pull request as ready for review March 13, 2023 07:05
@CloCkWeRX CloCkWeRX requested review from cesy, Br3nda and maco March 13, 2023 07:27
@CloCkWeRX
Copy link
Collaborator Author

Its. Working!

Try it out:

  • Codespaces, start new codespace off of this branch.
  • After waiting for it to build for ages, start your rails server and login!

image

I've updated the new contributors guide, and mucking around with VS Code locally seems to work nicely.

cesy
cesy reviewed Apr 13, 2023
View reviewed changes
.devcontainer/docker-compose.yml
APP_PROTOCOL: http
DEVISE_SECRET_KEY: secret
GROWSTUFF_EMAIL: "[email protected]"
GROWSTUFF_FLICKR_KEY: secretkey"
Copy link
Member

@cesy cesy Apr 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a missing or extra quote mark here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait, shouldn't merging have waited for an answer to this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured it was minor enough that it doesn't matter so long as the overall solution works, or indeed if everything in a codespace works except Flickr, that's not worth stopping merging.

cesy
cesy approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@cesy cesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge, thank you so much for finishing this off.

@cesy cesy merged commit 6c07be3 into dev Apr 13, 2023
@cesy cesy deleted the codespaces branch April 13, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesy cesy cesy approved these changes

@codeclimate codeclimate[bot] codeclimate left review comments

@Br3nda Br3nda Awaiting requested review from Br3nda

@maco maco Awaiting requested review from maco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CloCkWeRX @maco @cesy