Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-rails from 2.17.3 to 2.17.4 #3222

Merged
merged 1 commit into from
Dec 26, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 26, 2022

Bumps rubocop-rails from 2.17.3 to 2.17.4.

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.17.4

Bug fixes

  • #870: Fix an error for Rails/RootPathnameMethods when using Rails.env argument within Dir.glob. (@​koic)
  • #881: Fix a false positive for Rails/ActionControllerFlashBeforeRender when using flash in multiline rescue branch before redirect_to. (@​gurix)
  • #871: Fix a false positive for Rails/WhereMissing when left_joins(:foo) and where(foos: {id: nil}) separated by or, and. (@​ydah)
  • #875: Make Rails/RootPathnameMethods aware of enforced style of Style/StringLiterals. (@​koic)
  • #882: Fix false positive for Rails/UniqueValidationWithoutIndex with :conditions option. (@​etiennebarrie)
  • #821: Enhance Rails/TimeZone to accept methods with the :in timezone option. (@​fatkodima)

Changes

Changelog

Sourced from rubocop-rails's changelog.

2.17.4 (2022-12-25)

Bug fixes

  • #870: Fix an error for Rails/RootPathnameMethods when using Rails.env argument within Dir.glob. ([@​koic][])
  • #881: Fix a false positive for Rails/ActionControllerFlashBeforeRender when using flash in multiline rescue branch before redirect_to. ([@​gurix][])
  • #871: Fix a false positive for Rails/WhereMissing when left_joins(:foo) and where(foos: {id: nil}) separated by or, and. ([@​ydah][])
  • #875: Make Rails/RootPathnameMethods aware of enforced style of Style/StringLiterals. ([@​koic][])
  • #882: Fix false positive for Rails/UniqueValidationWithoutIndex with :conditions option. ([@​etiennebarrie][])
  • #821: Enhance Rails/TimeZone to accept methods with the :in timezone option. ([@​fatkodima][])

Changes

Commits
  • 836ff28 Cut 2.17.4
  • 3032b74 Update Changelog
  • b930670 Correctly detect Rails version when using only parts of the framework
  • b9f852b Use RuboCop RSpec 2.16
  • f8153ca Merge pull request #881 from gurix/fix/false_positive_for_rails_action_contro...
  • cb2de46 fixed false positive ActionControllerFlashBefore after rescue
  • f94b235 Merge pull request #871 from ydah/fix/where_missing
  • c23478a Merge pull request #882 from etiennebarrie/uniqueness-with-conditions
  • 61d3f6c Support conditions option of UniquenessValidator
  • c7e7de3 Support conditions specific to the validator
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Dec 26, 2022
Copy link
Member

@cesy cesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good once tests pass

Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.17.3 to 2.17.4.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rails@v2.17.3...v2.17.4)

---
updated-dependencies:
- dependency-name: rubocop-rails
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-rails-2.17.4 branch from 7b7e29e to 913cb48 Compare December 26, 2022 10:40
@cesy cesy merged commit cf224e1 into dev Dec 26, 2022
@cesy cesy deleted the dependabot/bundler/rubocop-rails-2.17.4 branch December 26, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant