Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/3155: Fix capybara link warning #3196

Merged
merged 7 commits into from
Dec 18, 2022

Conversation

italopires
Copy link
Contributor

@italopires italopires commented Dec 10, 2022

Changes Proposed in this Pull Request:

  • fix warning for have_link matcher: for selector :link must be an instance of String or Symbol. This will raise an error in a future version of Capybara. Called from

Fixes #3155

@italopires italopires changed the title Issue/3155: Fix warning link capybara Issue/3155: Fix capybara link warning Dec 11, 2022
@cesy
Copy link
Member

cesy commented Dec 12, 2022

Can you add yourself to our contributors list, please? One of the automated checks looks for that to make sure we give credit to everyone. Welcome to the project! And thanks for helping out with this.

@italopires
Copy link
Contributor Author

Can you add yourself to our contributors list, please? One of the automated checks looks for that to make sure we give credit to everyone. Welcome to the project! And thanks for helping out with this.

Done. It's a pleasure to contribute with Growstuff, thank you!!

@cesy

@cesy cesy added the future release For pull requests that are waiting on something else to go live first label Dec 14, 2022
@CloCkWeRX
Copy link
Collaborator

This seems safe to merge, as it's specs only.

@cesy cesy removed the future release For pull requests that are waiting on something else to go live first label Dec 17, 2022
@CloCkWeRX CloCkWeRX merged commit 13b99b4 into Growstuff:dev Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants