Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/1475: Ensure we have pagination #3193

Merged
merged 18 commits into from
Jan 21, 2024
Merged

Issues/1475: Ensure we have pagination #3193

merged 18 commits into from
Jan 21, 2024

Conversation

CloCkWeRX
Copy link
Collaborator

@CloCkWeRX CloCkWeRX commented Dec 10, 2022

Fixes #1475

Survey of code base:

  • app/controllers/garden_types_controller.rb
  • app/controllers/scientific_names_controller.rb
  • app/controllers/admin/members_controller.rb
  • app/controllers/admin/roles_controller.rb
  • app/controllers/admin_controller.rb
  • app/controllers/plant_parts_controller.rb
  • app/controllers/alternate_names_controller.rb
  • app/controllers/forums_controller.rb
  • Fix tests :(

cesy
cesy previously approved these changes Dec 10, 2022
Copy link
Member

@cesy cesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this helps

@cesy
Copy link
Member

cesy commented Dec 10, 2022

Oops, we've got some test failures, though

@cesy cesy self-requested a review December 10, 2022 08:38
@cesy cesy dismissed their stale review December 10, 2022 08:38

Missed a bit

@CloCkWeRX
Copy link
Collaborator Author

Oh. The failures are from a stub being passed in, with an array, where the actual code/pagination code is an ActiveRecord::Collection / similar.

@CloCkWeRX CloCkWeRX merged commit b77df88 into dev Jan 21, 2024
6 checks passed
@CloCkWeRX CloCkWeRX deleted the issues/1475 branch January 21, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants