Skip to content

Deprecate pokemon.getFavorite, rename to pokemon.isFavorite #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2016
Merged

Deprecate pokemon.getFavorite, rename to pokemon.isFavorite #230

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03f348c
deprecate getFavorite, rename to isFavorite
Jari27 Jul 26, 2016
3be6c6d
Adhere to checkstyle
Jari27 Jul 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/main/java/com/pokegoapi/api/pokemon/Pokemon.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,16 @@ public String getEggIncubatorId() {
public long getCreationTimeMs() {
return proto.getCreationTimeMs();
}

/**
* Checks whether the Pok�mon is set as favorite.
* @return true if the Pok�mon is set as favorite
*/
public boolean isFavorite(){
Copy link
Collaborator

@FabianTerhorst FabianTerhorst Jul 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a space between ){

return proto.getFavorite() > 0;
}

@Deprecated
public boolean getFavorite() {
return proto.getFavorite() > 0;
}
Expand Down