Skip to content

Added iv calculator #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2016
Merged

Added iv calculator #207

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0282767
Added iv calculator
Jari27 Jul 25, 2016
71d4968
checkstyleMain fix
Jari27 Jul 25, 2016
d9bd1a2
Fix @returns in doc of getIVRatio()
Jari27 Jul 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/main/java/com/pokegoapi/api/pokemon/Pokemon.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,14 @@ public int getIndividualDefense() {
public int getIndividualStamina() {
return proto.getIndividualStamina();
}

/**
* Calculates the pokemons IV ratio
Copy link
Collaborator

@jabbink jabbink Jul 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this break checkstyleMain because it does not contain a dot?

Copy link
Contributor Author

@Jari27 Jari27 Jul 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't get checkstyle to run. If I need to change it I will. I can also start working on annotating more of the classes.

Copy link
Collaborator

@FabianTerhorst FabianTerhorst Jul 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just change Calculates the pokemons IV ratio to Calculates the pokemons IV ratio.

* @return the pokemons IV ratio as a double between 0 and 1.0, 1.0 being perfect IVs
*/
public double getIVRatio() {
return (this.getIndividualAttack() + this.getIndividualDefense() + this.getIndividualStamina()) / 45.0;
}

public float getCpMultiplier() {
return proto.getCpMultiplier();
Expand Down