RequestHandler uses non-deamon threads

[noxone]

Description:
The class com.pokegoapi.main.RequestHandler contains a ExecutorService created by Executors.newFixedThreadPool(1). This leads to a non-daemon thread preventing the normal application shutdown.

Steps to reproduce:
Just log in successfully... the thread will then be there.

Expected behavior:
The thread should be a daemon thread.

Version:
using jar packed by jitpack from push 3df35da

[Aphoh]

What exactly do you mean when you say normal application shutdown? Shouldn't the application close all threads in the process like normal?

[svarzee]

I've observed the same issue but I'd rather have PokemonGo implement Closeable

[Jari27]

@Aphoh If the public void main()method exits, it doesn't close the requesthandler thread if it's not a daemon.

[Aphoh]

Ideally the RxJava pr will get merged and we wont have to worry about crazy threading stuff. I'm not too experienced in threading (android and rx is my specialty) so I can't speak much to this issue.
@Grover-c13 Do you have any thoughts?

[Grover-c13]

Yeah ive noticed this issue too. Will fix sometime, probably as @sadye suggests

[pvanassen]

The Runnable in the threadpool should stop if it receives an interruptedexception which happens at shutdown. On my app, when I send a shutdown signal, the thread indeed stops itself within a few seconds.

[Jari27]

Whoever is currently working with this, take a look at this.

http://stackoverflow.com/questions/13883293/turning-an-executorservice-to-daemon-in-java

[pvanassen]

Basically the same as starting a thread manually. Wasn't using any of the extra methods of the executor anyways.

[Jari27]

If you start a thread manually you can do myThread.setDaemon(true)

[pvanassen]

@sadye Check d13b8e1
It's already in Development

[Jari27]

So this should be closed then.

@Grover-c13
@jabbink
@Aphoh
@vmarchaud

[Grover-c13]

Yes ty