fix[cartesian]: Scalarization of temporaries#2558
Merged
romanc merged 2 commits intoMar 31, 2026
Merged
Conversation
Scalarization of read after write temporaries was eagerly scalarizing too many temporaries. If temporaries were written conditionaly, but read unconditionaly, the temporaries were still scalarized, leading to reads of undefined memory in case the condition for writing wasn't true. This PR changes `WriteBeforeReadTemporariesToScalars` to never scalarize if the write is conditional. This is defensive in the sense that if the read had the same condition, we could still scalarize. That functionality can be added later if deemed necessary.
Contributor
Author
|
FYI: The failing jobs on the GH box are due to ongoing maintenance. |
twicki
requested changes
Mar 31, 2026
Contributor
twicki
left a comment
twicki
left a comment
There was a problem hiding this comment.
Looks pretty clean already. I think I would change the default behavior to not error unless there is a compelling reason for it?
twicki
approved these changes
Mar 31, 2026
Contributor
Author
|
cscs-ci run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Scalarization of read after write temporaries was eagerly scalarizing too many temporaries. If temporaries were written conditionaly, but read unconditionaly, the temporaries were still scalarized, leading to reads of undefined memory in case the condition for writing wasn't true.
This PR changes
WriteBeforeReadTemporariesToScalarsto never scalarize if the write is conditional. This is defensive in the sense that if the read had the same condition, we could still scalarize. That functionality can be added later if deemed necessary./cc @FlorianDeconinck
Requirements
N/A