style[cartesian]: Cleanup in error messaging#2387
Merged
Merged
Conversation
FlorianDeconinck
changed the title
FlorianDeconinck
requested changes
Nov 13, 2025
romanc
requested changes
Nov 14, 2025
Contributor
romanc
left a comment
romanc
left a comment
There was a problem hiding this comment.
Please follow the pull request template. You can also add your name to the AUTHORS.md file (as explained in the template).
Do I see correctly that the changes in gtscript_frontend.py and `gtc/common.py are just formatting?
twicki
requested changes
Nov 14, 2025
twicki
changed the title
romanc
reviewed
Nov 24, 2025
Contributor
romanc
left a comment
romanc
left a comment
There was a problem hiding this comment.
Looks good now - just minor things inline.
FlorianDeconinck
approved these changes
Nov 25, 2025
Contributor
|
cscs-ci run |
1 similar comment
Contributor
|
cscs-ci run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Requirements
If this PR contains code authored by new contributors please make sure:
AUTHORS.mdfile adding the names of all the new contributors.