Skip to content

refactor[cartesian]: cleanups from oir -> treeir -> sdfg -> codegen workflow#2098

Merged
romanc merged 11 commits into
GridTools:mainfrom
romanc:romanc/cleanups-oir-treeir-sdfg
Jun 26, 2025
Merged

refactor[cartesian]: cleanups from oir -> treeir -> sdfg -> codegen workflow#2098
romanc merged 11 commits into
GridTools:mainfrom
romanc:romanc/cleanups-oir-treeir-sdfg

Conversation

@romanc
Copy link
Copy Markdown
Contributor

@romanc romanc commented Jun 24, 2025

Description

Refactors and cleanups from PR #2067, because that PR is way too large and we shouldn't bury refactors in there.

Requirements

  • All fixes and/or new features come with corresponding tests.
    New tests are added with this PR.
  • Important design decisions have been documented in the appropriate ADR inside the docs/development/ADRs/ folder.
    N/A

@romanc romanc marked this pull request as ready for review June 24, 2025 12:52
@romanc
Copy link
Copy Markdown
Contributor Author

romanc commented Jun 24, 2025

cscs-ci run

@romanc
Copy link
Copy Markdown
Contributor Author

romanc commented Jun 24, 2025

cscs-ci run

1 similar comment
@romanc
Copy link
Copy Markdown
Contributor Author

romanc commented Jun 25, 2025

cscs-ci run

Copy link
Copy Markdown
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/gt4py/cartesian/utils/base.py Outdated
@romanc romanc force-pushed the romanc/cleanups-oir-treeir-sdfg branch from 0a8b00c to a039e84 Compare June 25, 2025 12:21
romanc and others added 2 commits June 25, 2025 14:22
Co-authored-by: Enrique González Paredes <enriqueg@cscs.ch>
@romanc romanc force-pushed the romanc/cleanups-oir-treeir-sdfg branch from a039e84 to aa90257 Compare June 25, 2025 12:23
@romanc
Copy link
Copy Markdown
Contributor Author

romanc commented Jun 26, 2025

cscs-ci run

@romanc romanc merged commit 7168dc2 into GridTools:main Jun 26, 2025
31 checks passed
@romanc romanc deleted the romanc/cleanups-oir-treeir-sdfg branch June 26, 2025 06:34
stubbiali pushed a commit to stubbiali/gt4py that referenced this pull request Aug 19, 2025
…orkflow (GridTools#2098)

## Description

Refactors and cleanups from PR GridTools#2067, because that PR is way too large
and we shouldn't bury refactors in there.

## Requirements

- [x] All fixes and/or new features come with corresponding tests.
  New tests are added with this PR.
- [ ] Important design decisions have been documented in the appropriate
ADR inside the [docs/development/ADRs/](docs/development/ADRs/README.md)
folder.
  N/A

---------

Co-authored-by: Enrique González Paredes <enriqueg@cscs.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants