refactor[cartesian|next] Move imports of implementation down one level#2045
Merged
FlorianDeconinck merged 2 commits intoMay 22, 2025
Conversation
Describe how to access implementation sub-package
Co-authored-by: Enrique González Paredes <enriqueg@cscs.ch>
7 tasks
stubbiali
pushed a commit
to stubbiali/gt4py
that referenced
this pull request
Aug 19, 2025
GridTools#2045) ## Description As it stands now we have `gt4py.cartesian` and `gt4py.next `default importing themselves into the top level __init__.py . Now it isn't an issue per se, but it's a double import of a lot of files that ultimately will rarely be used in concert. This proposes to remove the "all" import and rely on users to actually call `gt4py.next` and `gt4py.cartesian` which I expect is the common case anyway. ## Requirements - [ ] All fixes and/or new features come with corresponding tests. - [ ] Important design decisions have been documented in the appropriate ADR inside the [docs/development/ADRs/](docs/development/ADRs/README.md) folder. --------- Co-authored-by: Enrique González Paredes <enriqueg@cscs.ch>
stubbiali
pushed a commit
to stubbiali/gt4py
that referenced
this pull request
Aug 19, 2025
GridTools#2045) ## Description As it stands now we have `gt4py.cartesian` and `gt4py.next `default importing themselves into the top level __init__.py . Now it isn't an issue per se, but it's a double import of a lot of files that ultimately will rarely be used in concert. This proposes to remove the "all" import and rely on users to actually call `gt4py.next` and `gt4py.cartesian` which I expect is the common case anyway. ## Requirements - [ ] All fixes and/or new features come with corresponding tests. - [ ] Important design decisions have been documented in the appropriate ADR inside the [docs/development/ADRs/](docs/development/ADRs/README.md) folder. --------- Co-authored-by: Enrique González Paredes <enriqueg@cscs.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As it stands now we have
gt4py.cartesianandgt4py.nextdefault importing themselves into the top level init.py . Now it isn't an issue per se, but it's a double import of a lot of files that ultimately will rarely be used in concert.This proposes to remove the "all" import and rely on users to actually call
gt4py.nextandgt4py.cartesianwhich I expect is the common case anyway.Requirements