Skip to content

feat[cartesian]: Feedback when a bad backend is selected#1544

Merged
FlorianDeconinck merged 2 commits into
GridTools:mainfrom
FlorianDeconinck:cartesian/better_bad_backend_feedback
May 16, 2024
Merged

feat[cartesian]: Feedback when a bad backend is selected#1544
FlorianDeconinck merged 2 commits into
GridTools:mainfrom
FlorianDeconinck:cartesian/better_bad_backend_feedback

Conversation

@FlorianDeconinck
Copy link
Copy Markdown
Contributor

@FlorianDeconinck FlorianDeconinck commented May 14, 2024

Description

Recent work with new user showed that basic mistake can lead to pretty gnarly stack trace instead of a clean error message. This fixes one of the most common: a bad backend name required.

Requirements

  • All fixes and/or new features come with corresponding tests.

Copy link
Copy Markdown
Contributor

@havogt havogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good.

@havogt
Copy link
Copy Markdown
Contributor

havogt commented May 16, 2024

cscs-ci run

@FlorianDeconinck FlorianDeconinck merged commit c89bd81 into GridTools:main May 16, 2024
@FlorianDeconinck FlorianDeconinck deleted the cartesian/better_bad_backend_feedback branch May 16, 2024 13:35
havogt added a commit that referenced this pull request Jun 20, 2024
Failure introduced after #1544,
but was wrong before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants