Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added dimension blacklist/whitelist to dungeon main settings #219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added dimension blacklist/whitelist to dungeon main settings #219

wants to merge 1 commit into from

Conversation

SanAndreaP
Copy link

added dimension blacklist/whitelist to dungeon main settings (spawn criteria), also fixed some settings issues:

  • prevent loading of other custom settings during spawn, even if the "main" file with its inherits has criteria filters
  • getCustom() should return null if it can't find a fitting custom setting
  • SpawnCriteria biome lists are now checked if they're empty instead of checking for a null instance, as these should not be null, ever

@SanAndreaP
added dimension blacklist/whitelist to dungeon main settings (spawn c…
4b4cbc5 
…riteria), also fixed some settings issues:

 * prevent loading of other custom settings during spawn, even if the "main" file with its inherits has criteria filters
 * getCustom() should return null if it can't find a fitting custom setting
 * SpawnCriteria biome lists are now checked if they're empty instead of checking for a null instance, as these should not be null, ever
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SanAndreaP