-
Notifications
You must be signed in to change notification settings - Fork 410
refactor!: remove export_metrics feature and related configuration/docs #6925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @kumarUjjawal There are some conflicts |
I will resolve those soon. |
dfeb3d8
to
9b03a5c
Compare
@WenyXu can you approve the workflow? |
Hi @kumarUjjawal, some CI checks have failed. Please follow the CI output for details. For |
Definitely, I will fix those. |
@WenyXu There are mentions of |
Yes |
Hi, please fix the CI checks and sign your commits. |
Hi, I found three variants of SNAFU error that are defined but never used anywhere, that's why one of the checks was failing, what is your preferences for that, should I remove those? |
The thee failing tests doesn't seem to come from my changes, Can you check? |
Sure, it's fine to remove them.
They are related to your changes. You should update the sqlness result because you have removed a table from the database. |
Oh! Thanks for the docs. |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
This PR is related to the issue #6907
What's changed and what's your intention?
As discussed in the issue #6907 the proposal was to Eliminate the
export_metrics
functionality and related documentation (including the standalone page) and remove theinformation_schema.runtime_metrics
table. I have hunt down all the refrences and removed as per my knowledge.PR Checklist
Please convert it to a draft if some of the following conditions are not met.