feat: add backend field to fulltext options#5806
Conversation
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
|
@zhongzc CI failed |
Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
killme2008
left a comment
There was a problem hiding this comment.
Good job! I wonder what happens in the following scenario:
- A column uses the tantivy backend initially, some rows are inserted, and indexes are built.
- The backend is altered to bloom.
Questions:
- Do the old tantivy indexes still work?
- Can both the new and old indexes work together?
|
The application of the index is determined by the generated index file, not the table structure, so the original index file can still take effect. The problem translates to whether both In principle, whether it's |
* feat: add backend field to fulltext options Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * update proto Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * fix option conv Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * fix display Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> * polish Signed-off-by: Zhenchi <zhongzc_arch@outlook.com> --------- Signed-off-by: Zhenchi <zhongzc_arch@outlook.com>
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
Wait for GreptimeTeam/greptime-proto#226
What's changed and what's your intention?
Add a backend field to FulltextOptions to prepare for future multi-backend support in fulltext index. Currently supports:
PR Checklist
Please convert it to a draft if some of the following conditions are not met.