Skip to content

fix: throw errors instead of ignoring#5792

Merged
WenyXu merged 27 commits intoGreptimeTeam:mainfrom
WenyXu:fix/alter-table
Apr 7, 2025
Merged

fix: throw errors instead of ignoring#5792
WenyXu merged 27 commits intoGreptimeTeam:mainfrom
WenyXu:fix/alter-table

Conversation

@WenyXu
Copy link
Member

@WenyXu WenyXu commented Mar 28, 2025 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

fixes #5796
#5798

What's changed and what's your intention?

This PR addresses issue #5796, which was caused by discrepancies in version handling between the datanode and metasrv. When a user first invokes the ALTER TABLE ... OPTIONS statement, the datanode does not increment the schema version, whereas the metasrv does. This results in a version mismatch between the metadata in metasrv and the datanode. During the processing of an alter request, the datanode checks the schema version from metasrv, and if they are inconsistent, it throws an "outdated request" error. However, the previous procedure implementation ignored the schema version mismatch error from the datanode (outdated request), leading to a situation where metasrv assumes the datanode has successfully updated the schema. Consequently, this results in a schema inconsistency between the datanode and metasrv.

This PR enhances the alter table procedure by

  • Throwing errors instead of silently ignoring them.
  • Remove schema version check in the datanode alter handling.

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@WenyXu WenyXu requested a review from MichaelScofield as a code owner March 28, 2025 06:40
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 28, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Mar 28, 2025
@WenyXu WenyXu requested review from a team, evenyag, v0y4g3r and waynexia as code owners March 28, 2025 10:28
@WenyXu WenyXu marked this pull request as draft March 28, 2025 10:53
@WenyXu WenyXu marked this pull request as ready for review March 31, 2025 11:05
fengjiachun
fengjiachun reviewed Apr 1, 2025
View reviewed changes
fengjiachun
fengjiachun approved these changes Apr 1, 2025
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

killme2008
killme2008 reviewed Apr 2, 2025
View reviewed changes
@killme2008
Copy link
Member

killme2008 commented Apr 2, 2025

Did we discuss the solution carefully, or was it just another attempt? @fengjiachun @evenyag @v0y4g3r

@WenyXu WenyXu force-pushed the fix/alter-table branch from 63372ec to f0f19b4 Compare April 2, 2025 09:52
@waynexia waynexia mentioned this pull request Apr 7, 2025
Closed
@WenyXu WenyXu mentioned this pull request Apr 7, 2025
Closed
2 tasks
fengjiachun
fengjiachun reviewed Apr 7, 2025
View reviewed changes
@WenyXu WenyXu force-pushed the fix/alter-table branch from 51e5c08 to a6e0ccb Compare April 7, 2025 12:44
evenyag
evenyag reviewed Apr 7, 2025
View reviewed changes
@WenyXu WenyXu force-pushed the fix/alter-table branch from 352c511 to f5b69f6 Compare April 7, 2025 13:29
@WenyXu WenyXu enabled auto-merge April 7, 2025 13:32
@WenyXu WenyXu added this pull request to the merge queue Apr 7, 2025
Merged via the queue into GreptimeTeam:main with commit 981d517 Apr 7, 2025
38 checks passed
@WenyXu WenyXu deleted the fix/alter-table branch April 7, 2025 14:12
WenyXu added a commit to WenyXu/greptimedb that referenced this pull request Apr 8, 2025
@WenyXu
fix: throw errors instead of ignoring (GreptimeTeam#5792)
9829c65 
* fix: throw errors instead of ignoring

* fix: fix unit tests

* refactor: remove schema version check

* fix: fix clippy

* chore: remove unused error

* refactor: remove schema version check

* feat: handle mutliple results

* feat: introduce consistency guard

* fix: release consistency guard on datanode operation completion

* test: add tests

* chore: remove schema version

* refactor: rename

* test: add more tests

* chore: print all error

* tests: query table after alteration

* log ignored request

* refine fuzz test

* chore: fix clippy and log mailbox message

* chore: close prepared statement after execution

* chore: add comment

* chore: remove log

* chore: rename to `ConsistencyPoison`

* chore: remove unused error

* fix: fix unit tests

* chore: apply suggestions from CR
killme2008 added a commit that referenced this pull request Apr 8, 2025
@WenyXu @discord9
@CookiePieWw @evenyag @waynexia @yihong0618 @killme2008
chore: bump version to 0.13.2 (#5837)
60852af 
* fix: mysql prepare bool value (#5732)

* fix: mysql prepare limit&offset param (#5734)

* fix: prepare limit&offset param

* test: sqlness

* chore: per review

* chore: per review

* fix: wrap table name with `` (#5748)

* fix: wrap table name with quotes

* fix: minor fix

* fix: handle nullable default value (#5747)

* fix: handle nullable default value

* chore: update sqlness

* fix: properly give placeholder types (#5760)

* fix: properly give placeholder types

* chore: update sqlness

* fix: support __name__ matcher in label values (#5773)

* fix: typo variadic (#5800)

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

* fix: close issue #3902 since upstream fixed (#5801)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>

* fix: correct error status code (#5802)

* fix: interval cast expression can't work in range query, #5805 (#5813)

* fix: interval cast expression can't work in range query, #5805

* fix: nested cast

* test: make vector test stable

* feat: introduce poison mechanism for procedure  (#5822)

* feat: introduce poison for procedure

* tests: add unit tests

* refactor: minor refactor

* fix: unit tests

* chore: fix unit tests

* chore: apply suggestions from CR

* chore: apply suggestions from CR

* chore: update comments

* chore: introduce `ProcedureStatus::Poisoned`

* chore: upgrade greptime-proto to `2be0f`

* chore: apply suggestions from CR

* fix: throw errors instead of ignoring (#5792)

* fix: throw errors instead of ignoring

* fix: fix unit tests

* refactor: remove schema version check

* fix: fix clippy

* chore: remove unused error

* refactor: remove schema version check

* feat: handle mutliple results

* feat: introduce consistency guard

* fix: release consistency guard on datanode operation completion

* test: add tests

* chore: remove schema version

* refactor: rename

* test: add more tests

* chore: print all error

* tests: query table after alteration

* log ignored request

* refine fuzz test

* chore: fix clippy and log mailbox message

* chore: close prepared statement after execution

* chore: add comment

* chore: remove log

* chore: rename to `ConsistencyPoison`

* chore: remove unused error

* fix: fix unit tests

* chore: apply suggestions from CR

---------

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Co-authored-by: discord9 <55937128+discord9@users.noreply.github.com>
Co-authored-by: Yohan Wal <profsyb@gmail.com>
Co-authored-by: Yingwen <realevenyag@gmail.com>
Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
Co-authored-by: yihong <zouzou0208@gmail.com>
Co-authored-by: dennis zhuang <killme2008@gmail.com>
@evenyag evenyag mentioned this pull request Jun 21, 2025
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@killme2008 killme2008 killme2008 left review comments

@fengjiachun fengjiachun fengjiachun approved these changes

@evenyag evenyag evenyag approved these changes

@MichaelScofield MichaelScofield Awaiting requested review from MichaelScofield MichaelScofield is a code owner

@v0y4g3r v0y4g3r Awaiting requested review from v0y4g3r v0y4g3r is a code owner

@waynexia waynexia Awaiting requested review from waynexia waynexia is a code owner

Assignees

No one assigned

Labels

docs-not-required This change does not impact docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CRITICAL] Add column after altering table options causing crashes

4 participants

@WenyXu @killme2008 @fengjiachun @evenyag