build: add RUSTUP_WINDOWS_PATH_ADD_BIN env#3969
Merged
Conversation
evenyag
force-pushed
the
ci/windows-nextest
branch
from
36d8c2a to
01c16f5
Compare
evenyag
changed the title
tisonkun
approved these changes
May 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3969 +/- ##
==========================================
- Coverage 85.37% 85.36% -0.02%
==========================================
Files 978 978
Lines 168276 168276
==========================================
- Hits 143661 143641 -20
- Misses 24615 24635 +20 |
WenyXu
approved these changes
May 17, 2024
WenyXu
pushed a commit
to WenyXu/greptimedb
that referenced
this pull request
May 17, 2024
build: add RUSTUP_WINDOWS_PATH_ADD_BIN: 1
WenyXu
pushed a commit
to WenyXu/greptimedb
that referenced
this pull request
May 21, 2024
build: add RUSTUP_WINDOWS_PATH_ADD_BIN: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Sets RUSTUP_WINDOWS_PATH_ADD_BIN to 1 to fix the release action, according to nextest-rs/nextest#1493
Checklist