Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support grpc for otlp trace and metrics #3105

Merged

Conversation

fengys1996
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This pr mainly change:

  1. Add support for otlp's grpc protocol.
  2. Add grpc auth middleware.
  3. Add a GrpcServerBuilder.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the docs-required This change requires docs update. label Jan 5, 2024
@fengys1996 fengys1996 force-pushed the feat/support_grpc_otlp_trace branch from e8f9d2c to 131b6e1 Compare January 5, 2024 08:39
@fengys1996 fengys1996 marked this pull request as ready for review January 5, 2024 08:56
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 95 lines in your changes are missing coverage. Please review.

Comparison is base (122b472) 85.71% compared to head (2272a2c) 85.14%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3105      +/-   ##
==========================================
- Coverage   85.71%   85.14%   -0.58%     
==========================================
  Files         812      815       +3     
  Lines      132958   133218     +260     
==========================================
- Hits       113964   113425     -539     
- Misses      18994    19793     +799     

@fengys1996 fengys1996 force-pushed the feat/support_grpc_otlp_trace branch from e247303 to 38f71e5 Compare January 9, 2024 02:32
Copy link
Contributor

@shuiyisong shuiyisong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/servers/src/grpc/otlp.rs Outdated Show resolved Hide resolved
src/servers/src/grpc/otlp.rs Outdated Show resolved Hide resolved
@fengys1996 fengys1996 added this pull request to the merge queue Jan 9, 2024
Merged via the queue into GreptimeTeam:main with commit 6e860bc Jan 9, 2024
15 checks passed
@fengys1996 fengys1996 deleted the feat/support_grpc_otlp_trace branch January 9, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required This change requires docs update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants