Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add update metadata step for upgrading candidate region #2802

Closed

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Nov 23, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add update metadata step for upgrading candidate region

Behaviors:

Abort(non-retry):

  • TableRoute or RegionRoute is not found.
    Typically, it's impossible, there is no other DDL procedure executed concurrently for the current table.

Retry:

  • Failed to update TableRouteValue
  • Failed to retrieve the metadata of the table.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2700

@WenyXu WenyXu mentioned this pull request Nov 23, 2023
39 tasks
@WenyXu WenyXu self-assigned this Nov 23, 2023
@WenyXu WenyXu force-pushed the feat/update-metadata-upgrading branch from de51e70 to 2bc4fec Compare November 23, 2023 10:35
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #2802 (2bc4fec) into develop (102e43a) will decrease coverage by 0.36%.
Report is 3 commits behind head on develop.
The diff coverage is 92.81%.

❗ Current head 2bc4fec differs from pull request most recent head 76d83a4. Consider uploading reports for the commit 76d83a4 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2802      +/-   ##
===========================================
- Coverage    84.68%   84.32%   -0.36%     
===========================================
  Files          730      732       +2     
  Lines       113711   113997     +286     
===========================================
- Hits         96291    96132     -159     
- Misses       17420    17865     +445     

@WenyXu WenyXu closed this Nov 24, 2023
@WenyXu WenyXu deleted the feat/update-metadata-upgrading branch November 24, 2023 07:34
@WenyXu WenyXu restored the feat/update-metadata-upgrading branch November 24, 2023 07:34
@WenyXu
Copy link
Member Author

WenyXu commented Nov 24, 2023

My bad, I can't reopen this PR again. Moved to #2811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant