Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: heartbeat response contains region role #2718

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Nov 9, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Make heartbeat response contain region role

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2700
close #2639

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #2718 (93f9167) into develop (9d029f7) will decrease coverage by 0.50%.
Report is 3 commits behind head on develop.
The diff coverage is 93.47%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2718      +/-   ##
===========================================
- Coverage    85.29%   84.79%   -0.50%     
===========================================
  Files          763      765       +2     
  Lines       123509   123940     +431     
===========================================
- Hits        105343   105100     -243     
- Misses       18166    18840     +674     

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue Nov 9, 2023
Merged via the queue into GreptimeTeam:develop with commit a361151 Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor heartbeat to contains region role
3 participants