Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add leader_status for RegionRoute #2670

Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Oct 31, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

We should downgrade a Region before deactivating it:

  • During the Region Failover Procedure.
  • Migrating a Region.

Notes: Meta Server will stop renewing the lease for the downgraded [Region].

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2638

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #2670 (8ce4b0a) into develop (d77003f) will decrease coverage by 0.40%.
The diff coverage is 94.33%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2670      +/-   ##
===========================================
- Coverage    85.04%   84.64%   -0.40%     
===========================================
  Files          740      740              
  Lines       120457   120510      +53     
===========================================
- Hits        102440   102008     -432     
- Misses       18017    18502     +485     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield added this pull request to the merge queue Oct 31, 2023
Merged via the queue into GreptimeTeam:develop with commit e3320c5 Oct 31, 2023
@WenyXu WenyXu mentioned this pull request Nov 6, 2023
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants