Skip to content

Commit

Permalink
chore: use --metasrv-addrs instead (#156)
Browse files Browse the repository at this point in the history
  • Loading branch information
discord9 authored Jul 2, 2024
1 parent 3fda765 commit a61c8ac
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions apis/v1alpha1/defaulting_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ func TestSetDefaults(t *testing.T) {
MainContainer: &MainContainerSpec{
Image: "greptime/frontend:latest",
Args: []string{
"--metasrv-addr",
"--metasrv-addrs",
"meta.default:3002",
},
},
Expand Down Expand Up @@ -238,7 +238,7 @@ func TestSetDefaults(t *testing.T) {
MainContainer: &MainContainerSpec{
Image: "greptime/frontend:latest",
Args: []string{
"--metasrv-addr",
"--metasrv-addrs",
"meta.default:3002",
},
Resources: corev1.ResourceRequirements{
Expand Down
2 changes: 1 addition & 1 deletion controllers/greptimedbcluster/deployers/datanode.go
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ func (b *datanodeBuilder) BuildPodMonitor() deployer.Builder {
func (b *datanodeBuilder) generateMainContainerArgs() []string {
return []string{
"datanode", "start",
"--metasrv-addr", fmt.Sprintf("%s.%s:%d", common.ResourceName(b.Cluster.Name, v1alpha1.MetaComponentKind),
"--metasrv-addrs", fmt.Sprintf("%s.%s:%d", common.ResourceName(b.Cluster.Name, v1alpha1.MetaComponentKind),
b.Cluster.Namespace, b.Cluster.Spec.Meta.ServicePort),
// TODO(zyy17): Should we add the new field of the CRD for datanode http port?
"--http-addr", fmt.Sprintf("0.0.0.0:%d", b.Cluster.Spec.HTTPServicePort),
Expand Down
2 changes: 1 addition & 1 deletion controllers/greptimedbcluster/deployers/frontend.go
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ func (b *frontendBuilder) generateMainContainerArgs() []string {
var args = []string{
"frontend", "start",
"--rpc-addr", fmt.Sprintf("0.0.0.0:%d", b.Cluster.Spec.GRPCServicePort),
"--metasrv-addr", fmt.Sprintf("%s.%s:%d", common.ResourceName(b.Cluster.Name, v1alpha1.MetaComponentKind),
"--metasrv-addrs", fmt.Sprintf("%s.%s:%d", common.ResourceName(b.Cluster.Name, v1alpha1.MetaComponentKind),
b.Cluster.Namespace, b.Cluster.Spec.Meta.ServicePort),
"--http-addr", fmt.Sprintf("0.0.0.0:%d", b.Cluster.Spec.HTTPServicePort),
"--mysql-addr", fmt.Sprintf("0.0.0.0:%d", b.Cluster.Spec.MySQLServicePort),
Expand Down

0 comments on commit a61c8ac

Please sign in to comment.