-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method to finalize config into initialization mode #47
Conversation
It is useful for applications to be able to decide when to bring MCAN into operational mode. Therefore, add the option for user to finalize the configuration into initialization mode rather than operational mode directly.
053c64c
to
63e5e21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes. This is a good idea, just one comment 🙂 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved 😃
- Add safe way to shutdown the bus when actively transmitting/receiving (GrepitAB#45) - Add method to finalize configuration into initialization mode (GrepitAB#47) - *Breaking* Update the register mappings with svd2rust 0.30.2 and form 0.10.0 (GrepitAB#46)
- Add safe way to shutdown the bus when actively transmitting/receiving (GrepitAB#45) - Add method to finalize configuration into initialization mode (GrepitAB#47) - *Breaking* Update the register mappings with svd2rust 0.30.2 and form 0.10.0 (GrepitAB#46)
It is useful for applications to be able to decide when to bring MCAN into operational mode. Therefore, add the option for user to finalize the configuration into initialization mode rather than operational mode directly.
Thank you!
Thank you for your contribution.
Please make sure that your submission includes the following:
Must
errors
orwarnings
.cargo +stable fmt
was run.cargo +stable clippy
yields nowarnings
.CHANGELOG.md
in the proper section.newly added features and code.