Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to finalize config into initialization mode #47

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

epontan
Copy link
Collaborator

@epontan epontan commented Mar 4, 2024

It is useful for applications to be able to decide when to bring MCAN into operational mode. Therefore, add the option for user to finalize the configuration into initialization mode rather than operational mode directly.

Thank you!

Thank you for your contribution.
Please make sure that your submission includes the following:

Must

  • The code compiles without errors or warnings.
  • All tests pass and in the best case you also added new tests.
  • cargo +stable fmt was run.
  • cargo +stable clippy yields no warnings.
  • Your changes were added to the CHANGELOG.md in the proper section.
  • You add a description of your work to this PR.
  • You added proper docs (in code, rustdoc and README.md) for your
    newly added features and code.

@epontan epontan requested a review from a team as a code owner March 4, 2024 13:37
It is useful for applications to be able to decide when to bring MCAN
into operational mode. Therefore, add the option for user to finalize
the configuration into initialization mode rather than operational mode
directly.
@epontan epontan force-pushed the finalize-into-init branch from 053c64c to 63e5e21 Compare March 4, 2024 13:38
@epontan epontan requested review from Ironedde and vcrn March 4, 2024 13:41
Copy link
Contributor

@Ironedde Ironedde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes. This is a good idea, just one comment 🙂 👍

Copy link

@vcrn vcrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@Ironedde Ironedde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 😃

@epontan epontan merged commit 472068e into GrepitAB:master Mar 4, 2024
5 checks passed
Ironedde added a commit to Ironedde/mcan-clone that referenced this pull request Mar 4, 2024
- Add safe way to shutdown the bus when actively transmitting/receiving
(GrepitAB#45)
- Add method to finalize configuration into initialization mode (GrepitAB#47)

- *Breaking* Update the register mappings with svd2rust 0.30.2 and
form 0.10.0 (GrepitAB#46)
@Ironedde Ironedde mentioned this pull request Mar 4, 2024
7 tasks
Ironedde added a commit to Ironedde/mcan-clone that referenced this pull request Mar 4, 2024
- Add safe way to shutdown the bus when actively transmitting/receiving
(GrepitAB#45)
- Add method to finalize configuration into initialization mode (GrepitAB#47)

- *Breaking* Update the register mappings with svd2rust 0.30.2 and
form 0.10.0 (GrepitAB#46)
Ironedde added a commit that referenced this pull request Mar 4, 2024
### Added
- Add safe way to shutdown the bus when actively transmitting/receiving
(#45)
- Add method to finalize configuration into initialization mode (#47)

### Changed
- *Breaking* Update the register mappings with svd2rust 0.30.2 and form
0.10.0 (#46)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants