Port Clipboard to GT

[bruberu]

As for now, this PR is not complete, since there are several sections that I am unable to resolve as of the moment. What currently needs fixing as of the moment is:

• Creating actual blockstates for the clipboard, as the default as of the moment appears to be air for no known reason.
• Rendering the normal clipboard model in all orientations.
• Rendering the clipboard block's contained ItemStack's GUI on top of the paper portion of the clipboard.
• Allowing the user to interact with the rendered GUI.

I particularly call on @DStrand1 and @Yefancy to help with some of these, since they have proven themselves to be extremely competent in these areas.

[Yefancy]

Nice work. I can feel that you put a lot of effort into learning rendering and put it into action. However, the current code may be a bit unreasonable in somewhere, which it is not worthwhile to implement a CCL renderer (TileEntityClipboardRenderer) and even write a dedicated model baker (ModelClipboard). And in order to use the widget you write a new UIFactory (TileEntityClipboardUIFactory) don't have to actually, you can still use the MTE, because of your TE (TileEntityClipboard) didn't do anything MTE cannot be achieved.

In fact, the concepts of model baking and real-time rendering are hard to explain in one sentence. You're basically writing model baking code. But you just need to understand that you only need to focus on real-time rendering, which is rendering a GUI.

I know why you used TE, because you found that MTE can't render non-cube models. But you can register the model and then render the model using the original Baker model, and you just need to render the GUI.

Anyway, it's a good start. I suggest you take a look at the Chest(MetaTileEntityChest) and the Tank(MetaTileEntityQuantumTank) code in GTCE, which is simple to implement and close to your stuff. The only difference between you is that the Chest has no model file and you have to render a model first.

Here's what I think the better way to do it:

1. new mte extends MetaTileEntity and implements IRenderMetaTileEntity (or IFastRenderMetaTileEntity, if you know how to improve performance by FASTTESR).
2. register and get your model (ModelLoaderRegistry.getModel(resourceLocation).bake()).
3. override method(renderMetaTileEntity) with empty body.
4. render your model and gui in renderMetaTileEntityDynamic or(renderMetaTileEntityFast).

If you want to do it withthe code that you already have:

1. First you have to give up CCL, which is a render once into the pipeline, and is definitely not the way you would expect. You also have interactions, you'd better not scheduling chunk pipline very often. To improve performance consider FastTESR plz.
2. Continue to use TE, but don't write a new iModeBake, it's not necessary, just use the original and render it as a normal block model.
3. Register TESR or FastTESR to render your GUI.

[bruberu]

@Yefancy I'm having some trouble with registering the model for this special MTE, unfortunately. It turns out that there isn't a good way to access the MTE from BlockMachine's blockstate, which prevents me from using it in the statemapper to register several different models under that particular block. Do you have any ideas on how to fix this so I can continue to use MTEs?

[TechLord22]

I don't really understand much of the real meat to this PR, so my review conists of quite minor things overall. I'll approve this PR if/when someone else approves it with a proper full-dephth review.

[TechLord22]

Can this be moved to be alphabetically in order with the others?

[Yefancy]

Have you tested this with the client and server separated?

[Yefancy]

I think you did a lot of changes to make it work, it would be better if have a simplify implementation but overall I think its ok. It just introduces a lot of helper classes, but I think we'll need them in the future

[htmlcsjs]

I dont think im the best qualified to review this, but i found a bug so ¯_(ツ)_/¯

[htmlcsjs]

This seems to be failing when you shift click to remove it, creating "no texture" particles. I cannot replicate it when doing things that normally cause particles to appear, such as running and jumping

[bruberu]

Have you tested this with the client and server separated?

No, although I certainly wish I was able to. Due to a fairly bad laptop, if I attempted to test this on my PC, it's unlikely that it would manage to actually run both instances at once without an extreme amount of lag, or crashing. A volunteer could certainly help with doing this test, although I'm probably not equipped to do that one right now.

[Yefancy]

When I test it, I found some bugs. For example, page turning in GUI doesn't display the current page correctly, picking items in creative mode gives you weird items, and the border overlay for holding a wrench has an unreasonable size.