Improved number formatting, with a couple of other fixes #1467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Improved number formatting to include thousands seperators according to locale.
How solved:
Changed %d in the language file to %,d
Outcome:
Does some of #1323
Additional info:
While doing this I discovered a few places where %d was used when it should have been using %s or %f
I also found that the code for slot widget in the crafting table used gregtech.item_list.item_stored while the language file was gregtech.item_list.items_stored, I changed the language file.
There are some places like the multiblock boiler or the gt util hand command that use minecraft's TextComponentTransalation api. This doesn't work with %,d so I didn't change these. Other places that use this api in the code, format numbers using %s.
I haven't touched the russian or chinese translations. They will not have the thousands seperators until somebody that speaks those languages does the same excercise.
Possible compatibility issue:
If one of the addon mods is reusing some of these translations, it may break their display if they have the same misuse as the %s and %f issue I fixed.