Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] WorldPipeNet WorldSavedData is not handled correctly #1398

Open
warjort opened this issue Jan 16, 2021 · 0 comments · May be fixed by #1399
Open

[BUG] WorldPipeNet WorldSavedData is not handled correctly #1398

warjort opened this issue Jan 16, 2021 · 0 comments · May be fixed by #1399
Labels
status: unverified type: bug Something isn't working

Comments

@warjort
Copy link
Contributor

warjort commented Jan 16, 2021

Describe the bug
The code for saving pipenets in the WorldSavedData assumes it is "multiplexed" by world/dimension.
e.g. The pipenets only store chunk and block positions with the actual world coming from the WorldPipeNet.

This assumption is not correct, Minecraft saves all dimensions in one WorldSavedData file for a data id.

Additionally, there are a few places that are trying to access pipenet data on the client world, such as the damage
from hot pipes or uninsulated cables. In fact, this is being done twice, once against the server world and once on the client.
I don't think it actually causes a real problem in the current code, but this could potentially have the client trying to modify the pipenet data in competition with the server.

Versions
Forge: 14.23.5.2854
GTCE: 1.10.9.612 (current from GitHub)

Steps To Reproduce

  1. In the overworld try to fill a wooden fluid pipe with steam
  2. It will burn
  3. Repeat the process in the nether
  4. It won't burn

Expected behavior
The reason why it won't burn in the nether is because it is trying to burn a block in the overworld with the same blockpos

I have a fix for these issues, which I will try to submit as a PR once I figure out how GitHub works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: unverified type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant