Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Planter list for tree/id #1694

Closed
wants to merge 4 commits into from
Closed

Planter list for tree/id #1694

wants to merge 4 commits into from
+0 −0

Conversation

aayushgauba
Copy link

@aayushgauba aayushgauba commented Jul 20, 2023 •
edited
Loading

image

fixes #1588

@dadiorchen dadiorchen changed the base branch from main to v2 July 21, 2023 01:21
@dadiorchen dadiorchen changed the base branch from v2 to main July 21, 2023 01:21
@dadiorchen
Copy link
Collaborator

@aayushgauba good job!

There are two things:

  1. Because this is v2 feature, did you work on v2 branch? But your PR is based by main and seems you checked out main to work on?
  2. The integration CI is broken, please check it, I suggest you migrate your work to v2 then raise PR again to see if everything is fine.

@aayushgauba aayushgauba changed the base branch from main to v2 July 21, 2023 04:14
@aayushgauba aayushgauba changed the base branch from v2 to main July 21, 2023 04:15
@aayushgauba
Copy link
Author

@dadiorchen Got it, I completely missed that part

@aayushgauba aayushgauba closed this by deleting the head repository Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add people who grows this tree list on /trees/{id} page
2 participants
@aayushgauba @dadiorchen