Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: grower tooltip jumping for errors #678

Merged
merged 2 commits into from
Jun 12, 2022

Conversation

mayankbucha
Copy link
Contributor

@mayankbucha mayankbucha commented Jun 5, 2022

Description

Large tooltip size (in cases for error) causes it to exceed size of the current wrapper which adds another scrollbar resulting in decreased width of the document.
Now in cases of wrong grower url, default image is shown.

Issue(s) addressed

What kind of change(s) does this PR introduce?

  • Enhancement
  • Bug fix
  • Refactor

Please check if the PR fulfils these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Issue

Resolves #660

What is the current behavior?

Large tooltip causes jumps.

What is the new behavior?

Error tooltip size is reduced which eliminates jump.

Breaking change

Does this PR introduce a breaking change?

No

@mayankbucha mayankbucha requested a review from a team as a code owner June 5, 2022 20:16
Copy link
Collaborator

@nmcharlton nmcharlton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @mayankbucha

@nmcharlton nmcharlton merged commit 88403b6 into Greenstand:master Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Growers tooltip is jumpy
2 participants