Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make collapsed section header clickable #20317

Merged
merged 5 commits into from
Sep 2, 2024
Merged

Make collapsed section header clickable #20317

merged 5 commits into from
Sep 2, 2024

Conversation

ousmaneo
Copy link
Contributor

@ousmaneo ousmaneo commented Aug 30, 2024 •
edited
Loading

fix Graylog2/graylog-plugin-enterprise#8384 Graylog2/graylog-plugin-enterprise#8147
/nocl

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

ousmaneo and others added 5 commits August 30, 2024 16:41
@ousmaneo
make collapsed secton header clickable
62a15cb 
- make section header color change on hover
@ousmaneo
Merge branch 'master' into stream-destination-tweaks
c5ebbd2
@ousmaneo
Merge branch 'master' into stream-destination-tweaks
63526b1
@ousmaneo
check permissions
8c0fa9c 
- check permission for outputs section
- check permission for Data routing
- rename View details to Data routing
@ousmaneo
fix lint
f875adf
@ousmaneo ousmaneo marked this pull request as ready for review September 2, 2024 10:20
@ousmaneo ousmaneo self-assigned this Sep 2, 2024
gally47
gally47 approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@gally47 gally47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, code lgtm.

@gally47 gally47 merged commit 725ed36 into master Sep 2, 2024
10 checks passed
@gally47 gally47 deleted the stream-destination-tweaks branch September 2, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gally47 gally47 gally47 approved these changes

@grotlue grotlue Awaiting requested review from grotlue

Assignees

@ousmaneo ousmaneo

Labels
ready-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ousmaneo @gally47