Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically remove index blocks during remote reindex migration #20313

Merged
merged 5 commits into from
Sep 13, 2024
Merged

Automatically remove index blocks during remote reindex migration #20313

merged 5 commits into from
Sep 13, 2024

Conversation

todvora
Copy link
Contributor

@todvora todvora commented Aug 30, 2024 •
edited
Loading

This PR adds automatic index block detection and removal during remote reindex migration.

Fixes https://github.com/Graylog2/graylog-plugin-enterprise/issues/8374

How Has This Been Tested?

Manually + extended integration test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@todvora todvora force-pushed the fix/remove-blocks-during-remote-reindex-migration branch from bbde73f to 434e46a Compare August 30, 2024 12:02
moesterheld
moesterheld approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@moesterheld moesterheld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine and lgtm. Thank you!

@moesterheld moesterheld merged commit 88a0747 into master Sep 13, 2024
6 checks passed
@moesterheld moesterheld deleted the fix/remove-blocks-during-remote-reindex-migration branch September 13, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvasylenko vvasylenko vvasylenko approved these changes

@moesterheld moesterheld moesterheld approved these changes

@luk-kaminski luk-kaminski Awaiting requested review from luk-kaminski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@todvora @vvasylenko @moesterheld