Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stream_data_routing types to queryValidation #20273

Merged

Conversation

ousmaneo
Copy link
Contributor

  • make PluggableControl left side a container
    /nocl

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@ousmaneo ousmaneo marked this pull request as ready for review August 30, 2024 10:09
Copy link
Contributor

@gally47 gally47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gally47 gally47 merged commit 958b084 into add_StreamQueryExplainer_interface Sep 2, 2024
7 checks passed
@gally47 gally47 deleted the stream_data_routing_search branch September 2, 2024 14:33
kodjo-anipah added a commit that referenced this pull request Sep 6, 2024
#20251)

* Added an StreamQueryExplainer interface for returning additional information on stream data locations

* Revert "Added an StreamQueryExplainer interface for returning additional information on stream data locations"

This reverts commit 413db4e.

* Add stream query explainer to query validation

* return a warning status warning when data routed stream is detected during query validation

* clean up

* make some members public so that we can access it in enterprise

* extend IndexRangeService interface to get ranges by streamId

* return provided timerange back as an absolut, so that we can trigger other actions based on the range

* move searched time range to context

* change interface to accept an query

* add a new query validation status info

* Add stream_data_routing types to queryValidation (#20273)

* add stream_data_routing type.

- make PluggableControl left side a container

* add searched_time_range to context

- update types

* capitalize Info status type in DTO

* handle info status in validation results

* remove container around search bar left column

* Update graylog2-web-interface/src/views/components/searchbar/queryvalidation/QueryValidation.tsx

Co-authored-by: Dennis Oelkers <[email protected]>

* Update graylog2-server/src/main/java/org/graylog/plugins/views/search/rest/QueryValidationResource.java

Co-authored-by: Dennis Oelkers <[email protected]>

* Revert "Update graylog2-server/src/main/java/org/graylog/plugins/views/search/rest/QueryValidationResource.java"

This reverts commit 3f64bc0.

* use optional.map to simplify the code

* fix linter error

* fix type

---------

Co-authored-by: Ousmane SAMBA <[email protected]>
Co-authored-by: Ousmane Samba <[email protected]>
Co-authored-by: Dennis Oelkers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants