-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stream_data_routing types to queryValidation #20273
Merged
gally47
merged 7 commits into
add_StreamQueryExplainer_interface
from
stream_data_routing_search
Sep 2, 2024
Merged
Add stream_data_routing types to queryValidation #20273
gally47
merged 7 commits into
add_StreamQueryExplainer_interface
from
stream_data_routing_search
Sep 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make PluggableControl left side a container
- update types
gally47
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
kodjo-anipah
added a commit
that referenced
this pull request
Sep 6, 2024
#20251) * Added an StreamQueryExplainer interface for returning additional information on stream data locations * Revert "Added an StreamQueryExplainer interface for returning additional information on stream data locations" This reverts commit 413db4e. * Add stream query explainer to query validation * return a warning status warning when data routed stream is detected during query validation * clean up * make some members public so that we can access it in enterprise * extend IndexRangeService interface to get ranges by streamId * return provided timerange back as an absolut, so that we can trigger other actions based on the range * move searched time range to context * change interface to accept an query * add a new query validation status info * Add stream_data_routing types to queryValidation (#20273) * add stream_data_routing type. - make PluggableControl left side a container * add searched_time_range to context - update types * capitalize Info status type in DTO * handle info status in validation results * remove container around search bar left column * Update graylog2-web-interface/src/views/components/searchbar/queryvalidation/QueryValidation.tsx Co-authored-by: Dennis Oelkers <[email protected]> * Update graylog2-server/src/main/java/org/graylog/plugins/views/search/rest/QueryValidationResource.java Co-authored-by: Dennis Oelkers <[email protected]> * Revert "Update graylog2-server/src/main/java/org/graylog/plugins/views/search/rest/QueryValidationResource.java" This reverts commit 3f64bc0. * use optional.map to simplify the code * fix linter error * fix type --------- Co-authored-by: Ousmane SAMBA <[email protected]> Co-authored-by: Ousmane Samba <[email protected]> Co-authored-by: Dennis Oelkers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/nocl
Types of changes
Checklist: