Datanode migration telemetry #20225
Merged
Datanode migration telemetry #20225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grotlue
requested changes
Sep 5, 2024
| const sendTelemetry = useSendTelemetry(); | ||
|
|
||
| const handleTabSwitch = (e) => { | ||
| sendTelemetry((e?.target?.innerText === 'Upload CA') |
There was a problem hiding this comment.
Would be nice to move Upload CA into a constant and reuse it at line 63 to avoid bugs.
| sendTelemetry(TELEMETRY_EVENT_TYPE.DATANODE_MIGRATION.MIGRATION_TYPE_SELECTED, { | ||
| app_pathname: 'datanode', | ||
| app_section: 'migration', | ||
| event_details: { migration_type: (step === 'SELECT_ROLLING_UPGRADE_MIGRATION') ? 'IN-PLACE' : 'REMOTE REINDEX' }, |
There was a problem hiding this comment.
Same here, constant for the step would be nice.
| import { TELEMETRY_EVENT_TYPE } from 'logic/telemetry/Constants'; | ||
| import type { TelemetryEventType } from 'logic/telemetry/TelemetryContext'; | ||
|
|
||
| import useMigrationState from '../../hooks/useMigrationState'; |
There was a problem hiding this comment.
Suggested change
| import useMigrationState from '../../hooks/useMigrationState'; | |
| import useMigrationState from 'components/datanode/hooks/useMigrationState'; |
...eb-interface/src/components/datanode/migrations/common/MigrationStepTriggerButtonToolbar.tsx
Show resolved
Hide resolved
grotlue
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
fixes #20086
Types of changes
Checklist: