Sorting of custom field types is null safe #19960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todvora
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Thanks for the fix, it looks good. Just one recommendation about the test. What about using an assertion like
Assertions.assertThat(comparator.compare(itemOne, itemTwo)).isNegative();
isNegative, isPositive and isZero assertions are nicely matching the contract of the comparator and make the test IMHO more readable.
luk-kaminski
force-pushed
the
fix/sorting_of_custom_field_types_is_null_safe
branch
from
4d0c088
to
55d20a9
Compare
|
Is it possible this can/will be backported to 6.0? |
Yes, hopefully I will do it today. |
luk-kaminski
added a commit
that referenced
this pull request
Jul 23, 2024
* Sorting of custom field types is null safe * Adding changelog * Using human language in assertions instead of mathematical operators (cherry picked from commit d20c795)
bernd
pushed a commit
that referenced
this pull request
Jul 23, 2024
* Sorting of custom field types is null safe * Adding changelog * Using human language in assertions instead of mathematical operators
janheise
pushed a commit
that referenced
this pull request
Jul 23, 2024
thll
pushed a commit
that referenced
this pull request
Jul 25, 2024
…9971) * Fix zstd library loading issue on noexec-mounted /tmp directories Set the "ZstdTempFolder" system property early in the startup process. Fixes #17837 * Add changelog entry. * Bump material-symbols from 0.15.0 to 0.21.1 in /graylog2-web-interface (#19892) * Bump material-symbols from 0.15.0 to 0.21.1 in /graylog2-web-interface Bumps [material-symbols](https://github.com/marella/material-symbols/tree/HEAD/material-symbols) from 0.15.0 to 0.21.1. - [Release notes](https://github.com/marella/material-symbols/releases) - [Commits](https://github.com/marella/material-symbols/commits/v0.21.1/material-symbols) --- updated-dependencies: - dependency-name: material-symbols dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Update icon names. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Linus Pahl <[email protected]> Co-authored-by: maxiadlovskii <[email protected]> * Sorting of custom field types is null safe (#19960) * Sorting of custom field types is null safe * Adding changelog * Using human language in assertions instead of mathematical operators * Check permission for stream column that needs it (#19956) Co-authored-by: Laura <[email protected]> * Add isFetching flag to useFieldTypes hook (#19978) * Create native lib dir and revert API change - The zstd library doesn't create its own temp dir, so we do it. - Restore the "getPluginLoader(File, ChainingClassloader)" method to avoid breaking subclasses. (e.g., Forwarder) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Linus Pahl <[email protected]> Co-authored-by: maxiadlovskii <[email protected]> Co-authored-by: luk-kaminski <[email protected]> Co-authored-by: Ousmane SAMBA <[email protected]> Co-authored-by: Laura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sorting of custom field types is null safe.
Fixes #19694
Motivation and Context
See #19694
How Has This Been Tested?
Manually and with new unit tests.
Types of changes
Checklist: