Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow remote opensearch connection checks in datanode rest api proxy #19932

Merged

Conversation

todvora
Copy link
Contributor

@todvora todvora commented Jul 17, 2024

New remote-reindex connection check in the datanodes needs to be accessible by default through our datanode proxy implementation in the graylog server. We need to add it to the default allowlist.

How Has This Been Tested?

Manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@todvora todvora requested a review from moesterheld July 18, 2024 07:02
Copy link
Contributor

@moesterheld moesterheld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thank you

@moesterheld moesterheld merged commit 5a98253 into master Jul 18, 2024
5 checks passed
@moesterheld moesterheld deleted the fix/datanode-remote-connection-check-api-allowlist branch July 18, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants