-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated GreyNoise Community Data Adapter #19927
Remove deprecated GreyNoise Community Data Adapter #19927
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryan-carroll-graylog The code changes here look good to me and test successfully.
One aside: I noticed that the adapter is not flagged as no longer working in the frontend with that alert icon.
The details page does show it's not working though:
I think removed inputs have a way that they show an error state that the input class is no longer available at the top-level. It would be helpful to users if something similar were supported for adapters at the top level list, maybe showing that same alert icon as is done when CSV files are no longer available. What do you think about creating a separate task for that and maybe we can look into it separately?
Ah great point, yeah I think something similar to inputs to notify users that the adapter won't work makes sense. Opening an issue for it now. |
Created issue: #19961 |
Description
Removes deprecated GreyNoise Community Data Adapter and associated messaging.
Motivation and Context
Closes: #19914
How Has This Been Tested?
Locally in dev environment.
Screenshots (if appropriate):
Types of changes
Checklist: