Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated GreyNoise Community Data Adapter #19927

Merged

Conversation

ryan-carroll-graylog
Copy link
Contributor

Description

Removes deprecated GreyNoise Community Data Adapter and associated messaging.

Motivation and Context

Closes: #19914

How Has This Been Tested?

Locally in dev environment.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@ryan-carroll-graylog ryan-carroll-graylog linked an issue Jul 16, 2024 that may be closed by this pull request
Copy link
Contributor

@danotorrey danotorrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryan-carroll-graylog The code changes here look good to me and test successfully.

One aside: I noticed that the adapter is not flagged as no longer working in the frontend with that alert icon.

image

The details page does show it's not working though:
image

I think removed inputs have a way that they show an error state that the input class is no longer available at the top-level. It would be helpful to users if something similar were supported for adapters at the top level list, maybe showing that same alert icon as is done when CSV files are no longer available. What do you think about creating a separate task for that and maybe we can look into it separately?

@ryan-carroll-graylog
Copy link
Contributor Author

I think removed inputs have a way that they show an error state that the input class is no longer available at the top-level. It would be helpful to users if something similar were supported for adapters at the top level list, maybe showing that same alert icon as is done when CSV files are no longer available. What do you think about creating a separate task for that and maybe we can look into it separately?

Ah great point, yeah I think something similar to inputs to notify users that the adapter won't work makes sense. Opening an issue for it now.

@ryan-carroll-graylog
Copy link
Contributor Author

ryan-carroll-graylog commented Jul 19, 2024

I think removed inputs have a way that they show an error state that the input class is no longer available at the top-level. It would be helpful to users if something similar were supported for adapters at the top level list, maybe showing that same alert icon as is done when CSV files are no longer available. What do you think about creating a separate task for that and maybe we can look into it separately?

Ah great point, yeah I think something similar to inputs to notify users that the adapter won't work makes sense. Opening an issue for it now.

Created issue: #19961

@ryan-carroll-graylog ryan-carroll-graylog merged commit a55bbde into master Jul 19, 2024
6 checks passed
@ryan-carroll-graylog ryan-carroll-graylog deleted the 19914-remove-deprecated-greynoise-data-adapters branch July 19, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Deprecated GreyNoise Data Adapters
3 participants