Assisted inject for datanode migration context #19926
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing MigrationActionsImpl was a singleton. We were setting the MigrationStateMachineContext to a singleton from different request threads, losing anything that the other thread could have written to the context before. This occured during parallel /state and /trigger request during migrations.
New implementation is using a factory for the MigrationActions, creating new instance for each request, propagating a new instance of MigrationStateMachineContext for each thread. This separates the actions contexts of several threads, never mixing them.
/nocl
Motivation and Context
Sometimes during the connection check in remote reindex migration, a message "No indexes available" has been displayed. There was no problem with the connection check itself, but due to the threading issue and context overriding, we lost the check info and never returned it.
How Has This Been Tested?
Manually + existing set of unit and integration tests.
Types of changes
Checklist: