Block field type changes in Illuminate index sets #19923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todvora
reviewed
Jul 17, 2024
graylog2-server/src/main/java/org/graylog2/indexer/indexset/IndexSetConfig.java
Outdated
Show resolved
Hide resolved
luk-kaminski
deleted the
fix/block_field_type_changes_for_illuminate_index_sets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Block field type and profile changes in Illuminate index sets.
/nocl
Motivation and Context
Field type and profile changes in Illuminate do not take place anyway, are silently ignored.
We want to explicitly block them, so that no one is surprised by that.
Partially solves #19766, but some FE blocks would make the solution even nicer.
How Has This Been Tested?
Manually and with new unit tests.
Types of changes
Checklist: