Datanode migration: fix invalid hostname #19894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todvora
requested changes
Jul 15, 2024
| if (host.endsWith("/")) { | ||
| host = host.substring(0, host.length() - 1); | ||
| } | ||
| final URI hostname = Objects.requireNonNull(URI.create(host), "hostname has to be provided"); |
There was a problem hiding this comment.
I think the order of checks is wrong here. It's too late to require a nonnull host if we use .endsWith before.
There was a problem hiding this comment.
good point. I think getActionArgument will already throw a IllegalArgumentException if the value is missing, but I added a check for a non blank string on top.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
silently removes trailing slash from hostname
/nocl
Motivation and Context
fixes #19884
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: